Exporter: allow extrapolation into excisions - Githubissues

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

153 stars 185 forks source link

Exporter: allow extrapolation into excisions #6056

Open nilsvu opened 1 month ago

nilsvu commented 1 month ago

Proposed changes

This is needed to fill the excision region with (non-constraint-satisfying) data so it can be imported into moving puncture codes.

Upgrade instructions

Code review checklist

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

Further comments

nilsvu commented 2 weeks ago

Thanks for your review @wthrowe! I pushed a fixup.

nilsvu commented 1 week ago

I'm investigating the NaNs in some of the unit tests, but the fixup is ready for your review @wthrowe