Add LTS CMake Option in GenHarmBase Executables

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

153 stars 185 forks source link

Closed AlexCarpenter46 closed 3 weeks ago

AlexCarpenter46 commented 1 month ago

Adds an option to either build in LTS or GTS for the executables that use GeneralizedHarmonicBase

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

AlexCarpenter46 commented 1 month ago

If we don't use or build EvolveGhCce or EvolveGhCcm can I delete them in this PR (saw a comment on this in slack)?

geoffrey4444 commented 1 month ago

Do you understand why the tests fail? Let's discuss if needed!

AlexCarpenter46 commented 1 month ago

Okay, got all the tests timing out figured out and clang-tidy so I think this is ready for a review :)

AlexCarpenter46 commented 1 month ago

Squashed the timout change in :) @knelli2

wthrowe commented 3 weeks ago

I'm fine with the settings in the files, but I still don't want comments telling people to shrink the slab to observe more.

knelli2 commented 3 weeks ago

@wthrowe So what is your suggestion if more frequent observation is needed? Dense triggers?

wthrowe commented 3 weeks ago

Yes.

AlexCarpenter46 commented 3 weeks ago

Okay, changed the comments in the yamls to suggest dense output, let me know if this works @wthrowe

wthrowe commented 3 weeks ago

Yes, that's fine.

knelli2 commented 3 weeks ago

Ignoring unrelated test timeouts/failures