Closed nilsdeppe closed 3 weeks ago
I've rebased this and set up auto deployment. I'm doing a final test on my fork to make sure it's working correctly, but I expect anything wrong would be a small typo in the last step of testing the CCE output is correct. This now bundles the CharacteristicExtract
and ReduceCceWoldtube
executables along with a BondiSachsR0200.h5
worldtube file, expected output file, and a python script that checks that things went okay. The last 3 parts are housed in our Google Drive since that was easiest to get working quick.
edit:
The release on my fork is running at https://github.com/nilsdeppe/spectre/actions/runs/9374720262/job/25811397363
This successfully deployed the executables on my fork. https://github.com/nilsdeppe/spectre/releases/tag/v2024.06.04.013
You can squash the fixups 👍
I've squashed, rebased, and squashed in a few of the other changes discussed. I think the bigger thing I'm hesitant to do is the workflow_call
part. I'd tried something like that previous and must've done something wrong because it didn't work at all as expected.
I squashed the --only-binary
change
Proposed changes
This adds most of the remaining code needed to CD the CCE executables.
The container is already push to the Dockerhub sxscollaboration image. I previously tested on my fork.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.Further comments