Add code to get common horizon coefs in ringdown distorted frame

geoffrey4444 commented 1 month ago

Proposed changes

This PR is the first in a set that will enable transitioning from merger to ringdown in binary black hole simulations. This PR adds a C++ function that reads in common horizon coefficients from a file and transforms them to the ringdown distorted frame. A future PR will add a pybinding to this function and use that binding in an update to the Ringdown pipeline.

Upgrade instructions

Code review checklist

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

Further comments

geoffrey4444 commented 1 month ago

I will fix the clang-tidy failures and look into why clang is happy but gcc isn't

geoffrey4444 commented 1 month ago

Clang-tidy is fixed, and the gcc test failures are fixed. The test that did fail is unrelated to this PR

geoffrey4444 commented 3 weeks ago

Test failures look to me unrelated to this PR

knelli2 commented 3 weeks ago

Yeah they do look unrelated, but I restarted them anyways. If there are still timeouts, I'll just merge this.

sxs-collaboration / spectre