BBH pipeline: fix default resolution parameters - Githubissues

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

153 stars 185 forks source link

BBH pipeline: fix default resolution parameters #6067

Closed nilsvu closed 3 weeks ago

nilsvu commented 1 month ago

These arguments have defaults in the CLI, so add them also to the standalone function. This fixes a bug when running generate-id --evolve.

Proposed changes

Upgrade instructions

Code review checklist

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

Further comments

nilsvu commented 3 weeks ago

I have no idea what went wrong with the macOS build, I just restarted it.

knelli2 commented 3 weeks ago

Ignoring macOS timeouts. Addressed in #6080.