Closed ffoucart closed 2 weeks ago
Currently, this PR uses the time step instead of the light crossing time in the implicit MC method, and hard codes some free parameters... fixing the first part requires some thinking about GZ, that I'll get back to before merging.
Rebased, and added the cell light crossing time as an input to the TakeTimeStep function, per discussion at the Spectre technical code meeting.
Rebased against develop, updated comments to reflect latest changes. Should be ready for review now.
Proposed changes
Replace standard rate calculation with methods accounting for implicit Monte Carlo.
Upgrade instructions
None
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.