sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Use mc high ka corr in time step #6069

Closed ffoucart closed 2 weeks ago

ffoucart commented 1 month ago

Proposed changes

Replace standard rate calculation with methods accounting for implicit Monte Carlo.

Upgrade instructions

None

Code review checklist

ffoucart commented 1 month ago

Currently, this PR uses the time step instead of the light crossing time in the implicit MC method, and hard codes some free parameters... fixing the first part requires some thinking about GZ, that I'll get back to before merging.

ffoucart commented 3 weeks ago

Rebased, and added the cell light crossing time as an input to the TakeTimeStep function, per discussion at the Spectre technical code meeting.

ffoucart commented 2 weeks ago

Rebased against develop, updated comments to reflect latest changes. Should be ready for review now.