Add dev guide for AMR - Githubissues

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

153 stars 185 forks source link

Add dev guide for AMR #6078

Closed kidder closed 2 weeks ago

kidder commented 3 weeks ago

Proposed changes

Upgrade instructions

Code review checklist

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

Further comments

wthrowe commented 2 weeks ago

Test failures are the numpy compatibility issue fixed in #6095. (Beats me why it only affects gcc 10 debug.)

nilsvu commented 2 weeks ago

@wthrowe the reason for only the one build being affected is that CI only installs Py dependencies if a specific Py version is being tested, otherwise the Py installation in the container is used. gcc-10 debug tests Py 3.9.

wthrowe commented 2 weeks ago

Makes sense. Thanks.