sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Run macOS tests on 2 cores #6080

Open knelli2 opened 3 weeks ago

knelli2 commented 3 weeks ago

Even though we have 4 cores available, charm tests start to time out because they require 2 cores each.

Proposed changes

I noticed that macOS CI keeps regularly timing out for some charm tests.

Upgrade instructions

Code review checklist

Further comments

knelli2 commented 3 weeks ago

Welp...this didn't fix it.

knelli2 commented 2 weeks ago

@nilsvu Should I close this or should we merge it? Things seem to be working now on other PRs so it was probably just something with the CI runners being busy/bogged down.

nilsvu commented 2 weeks ago

I suggest we test the updated macOS workflows in #5973 for a bit, which run on Apple Silicon on CI, and then see if we have to adjust timeouts