sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
159 stars 189 forks source link

Add stub M1 initial guess #6097

Closed pajkosmi closed 3 months ago

pajkosmi commented 3 months ago

Proposed changes

Adds framework to modify the initial guess for the implicit step of the M1 system.

Upgrade instructions

Code review checklist

Further comments

Currently, only the explicit solution is used for the initial guess. This file is unused for now.

pajkosmi commented 3 months ago

Yes, the updated M1 system would not yet use this. In fact, the future PRs I have for the M1Grey system makes use of imex::GuessExplicitResult. The purpose of this PR is to have the infrastructure available to change, if we need more accurate guesses. Is it better to just keep these changes on a local branch if that need ever arises and ignore this PR?

wthrowe commented 3 months ago

Yes, let's not add code unless we intend to use it.