Fix BuildDockerContainer workflow - Githubissues

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.

https://spectre-code.org

Other

159 stars 189 forks source link

Fix BuildDockerContainer workflow #6100

Closed nilsvu closed 3 months ago

nilsvu commented 3 months ago

This failed to build the CI container because we deleted it. Only build dev and dev1804 now, and combine the jobs into a matrix.

Proposed changes

Upgrade instructions

Code review checklist

[ ] The code is documented and the documentation renders correctly. Run make doc to generate the documentation locally into BUILD_DIR/docs/html. Then open index.html.
[ ] The code follows the stylistic and code quality guidelines listed in the code review guide.
[ ] The PR lists upgrade instructions and is labeled bugfix or new feature if appropriate.

Further comments

knelli2 commented 3 months ago

Wait why are we deleting the CI container?

nilsvu commented 3 months ago

We deleted it in #6060 and just install MPI and charm with MPI in the one CI build that use them. Just one fewer container to build.