sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
159 stars 189 forks source link

Add YlmsFromSpEC to shape time dependent options #6114

Closed knelli2 closed 3 weeks ago

knelli2 commented 3 months ago

Proposed changes

This is tangentially related to the PRs revamping the time dependent options for the Sphere and BCO domain creators.

This adds the ability to read the shape coefficients from a SpEC ID horizons dat file (not a dat file within an H5 file, but an actual dat file). If we are starting from SpEC ID (which we can do), then this is an important feature to have.

Upgrade instructions

Code review checklist

Further comments

~Depends on and includes #6109.~

knelli2 commented 2 months ago

No longer dependent. Also added a commit that adds FromVolumeFile to the shape map options

knelli2 commented 3 weeks ago

@nilsdeppe Squashed everything in. Thanks for the review

nilsdeppe commented 3 weeks ago

Wat, clang-tidy now doesn't want you to use l because it looks like I? Nobody should use font that doesn't allow you to tell the difference when writing code. My vote is disable that warning.

Edit: the std::uniform_real_distribution<double> distribution(0.1, 2.0); to a const should be okay to do and squash in(?)

knelli2 commented 3 weeks ago

Done!