Closed knelli2 closed 3 weeks ago
No longer dependent. Also added a commit that adds FromVolumeFile
to the shape map options
@nilsdeppe Squashed everything in. Thanks for the review
Wat, clang-tidy now doesn't want you to use l
because it looks like I
? Nobody should use font that doesn't allow you to tell the difference when writing code. My vote is disable that warning.
Edit: the std::uniform_real_distribution<double> distribution(0.1, 2.0);
to a const should be okay to do and squash in(?)
Done!
Proposed changes
This is tangentially related to the PRs revamping the time dependent options for the Sphere and BCO domain creators.
This adds the ability to read the shape coefficients from a SpEC ID horizons dat file (not a dat file within an H5 file, but an actual dat file). If we are starting from SpEC ID (which we can do), then this is an important feature to have.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.Further comments
~Depends on and includes #6109.~