Closed iago-mendes closed 1 week ago
@iago-mendes looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:
Metadata.yaml
file in the repository.Authors.Contributors
with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.
Proposed changes
I've implemented a Newton-Raphson iterative scheme with Broyden's method that controls the BBH masses and spins during the Initial Data. This follows a similar approach to what is described in section 2.3 of arXiv:1506.01689, except that here we control the Kerr masses and spins instead of the excision radii and horizon frequencies.
Upgrade instructions
If calling
generate_id
orid_parameters
fromInitialData.py
, you now need to specify the massesmass_a
andmass_b
separately instead of the previousmass_ratio
. Note thatgenerate_id_command
still takes inmass_ratio
as an argument.Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.Further comments