sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Control BBH masses and spins in initial data #6118

Closed iago-mendes closed 1 week ago

iago-mendes commented 1 week ago

Proposed changes

I've implemented a Newton-Raphson iterative scheme with Broyden's method that controls the BBH masses and spins during the Initial Data. This follows a similar approach to what is described in section 2.3 of arXiv:1506.01689, except that here we control the Kerr masses and spins instead of the excision radii and horizon frequencies.

Upgrade instructions

If calling generate_id or id_parameters from InitialData.py, you now need to specify the masses mass_a and mass_b separately instead of the previous mass_ratio. Note that generate_id_command still takes in mass_ratio as an argument.

Code review checklist

github-actions[bot] commented 1 week ago

@iago-mendes looks like this is your first contribution to SpECTRE. Welcome! 🎉 Your contribution is much appreciated, and we invite you to add your name to the author list:

  1. Edit the Metadata.yaml file in the repository.
  2. Add an entry to the list in Authors.Contributors with your name, affiliation, etc. Note that the list is ordered alphabetically by last name.
  3. Commit the change on a new branch and open a pull request with the change.

Once the pull request is merged, your name will appear on the SpECTRE DOI on Zenodo with the next public release.