sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
153 stars 185 forks source link

Add constraint preserving boundary condition product for ScalarTensor #6122

Closed guilara closed 6 days ago

guilara commented 1 week ago

Proposed changes

We write a boundary condition for the ScalarTensor system that combines the Bjorhus BCs for the metric sector and the constraint-preserving BC of CurvedScalarWave.

This is not a true constraint-preserving boundary condition since the gh BCs assume no backreaction of the scalar, and conversely, the constraint-preserving boundary conditions of the scalar assume a fixed spacetime geometry. I find that this approximation behaves well during evolution.

Upgrade instructions

Code review checklist

Further comments

guilara commented 6 days ago

@nilsdeppe Thanks for the review. Yes, I squashed them.