Closed pajkosmi closed 1 week ago
Please rebase now that #6076 is merged.
Please rebase now that #6076 is merged.
rebased
Ping, I freshly rebased and addressed the reviewer comments.
Don't delete the CMakeLists.txt
files, or at least the one in src
. That's preventing some of the CI checks from running.
The CMakeLists.txt
files you had before the fixup were fine, you were just missing the calls to add_subdirectory
in the parents.
squashed
You don't seem to have squashed.
You don't seem to have squashed.
edit: see below and ignore italics: When you say squash, do you mean squash all the fixups into 1 fixup commit (like it is now) or squash the 6 current commits (5 initial commits + 1 fixup commit) into 1 commit?
Regarding my previous comment, now I (think) I understand what you meant by squash. I have squashed the fixup commits into the previous relevant commits and rebased.
Everything has been addressed/rebased, except the ImplicitSourceJacobian.hpp
point I need clarification on above.
Comments addressed
Looks good. The test timeouts look unrelated to these changes, so don't worry about them. Go ahead and squash in the remaining fixups.
squashed
Proposed changes
Calculate Jacobian for M1 source terms. Also update M1 system to use Imex timestepper.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
. Then openindex.html
.bugfix
ornew feature
if appropriate.Further comments