sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
159 stars 189 forks source link

Add jacobian for hydro coupling source term #6132

Closed pajkosmi closed 1 week ago

pajkosmi commented 3 months ago

Proposed changes

Calculate Jacobian for M1 source terms. Also update M1 system to use Imex timestepper.

Upgrade instructions

Code review checklist

Further comments

wthrowe commented 3 months ago

Please rebase now that #6076 is merged.

pajkosmi commented 2 months ago

Please rebase now that #6076 is merged.

rebased

pajkosmi commented 1 month ago

Ping, I freshly rebased and addressed the reviewer comments.

wthrowe commented 1 month ago

Don't delete the CMakeLists.txt files, or at least the one in src. That's preventing some of the CI checks from running.

wthrowe commented 1 month ago

The CMakeLists.txt files you had before the fixup were fine, you were just missing the calls to add_subdirectory in the parents.

pajkosmi commented 1 month ago

squashed

wthrowe commented 1 month ago

You don't seem to have squashed.

pajkosmi commented 4 weeks ago

You don't seem to have squashed.

edit: see below and ignore italics: When you say squash, do you mean squash all the fixups into 1 fixup commit (like it is now) or squash the 6 current commits (5 initial commits + 1 fixup commit) into 1 commit?

pajkosmi commented 4 weeks ago

Regarding my previous comment, now I (think) I understand what you meant by squash. I have squashed the fixup commits into the previous relevant commits and rebased.

pajkosmi commented 2 weeks ago

Everything has been addressed/rebased, except the ImplicitSourceJacobian.hpp point I need clarification on above.

pajkosmi commented 1 week ago

Comments addressed

wthrowe commented 1 week ago

Looks good. The test timeouts look unrelated to these changes, so don't worry about them. Go ahead and squash in the remaining fixups.

pajkosmi commented 1 week ago

squashed