sxs-collaboration / sxs

Python code for manipulating data from the SXS collaboration
MIT License
26 stars 18 forks source link

Simulation metadata has negative value for number_of_orbits #114

Open Cyberface opened 3 days ago

Cyberface commented 3 days ago

Hi,

I noticed that the number_of_orbits in the metadata for the SXS:BBH:3683 simulation has a negative value.

Not sure if this is the best place to put this but hopefully it's helpful!

import sxs
df = sxs.load("simulations").dataframe
df[df['number_of_orbits'] < 0][['number_of_orbits']]
# SXS:BBH:3683 | -33.713913

Cheers!

moble commented 3 days ago

Thanks for reporting this, @Cyberface.

@markscheel I don't know how this number is computed, but a few points may be relevant:

  1. There seem to be a couple gaps in the horizon data.
  2. There is some weirdness in the waveform even at the outermost radius, at times that roughly correspond to the gaps in the horizon data.
  3. While there are ~800M of data for horizon C, there does not appear to be a merger or ringdown in the waveform.
import sxs
import matplotlib.pyplot as plt

sim = sxs.load("SXS:BBH:3683", extrapolation="Outer")
horizons = sim.horizons

plt.plot(horizons.A.time, horizons.A.coord_center_inertial)
plt.plot(horizons.B.time, horizons.B.coord_center_inertial, ls="dashed")
plt.plot(horizons.C.time, horizons.C.coord_center_inertial, ls="dotted")
plt.legend(["$A_x$", "$A_y$", "$A_z$", "$B_x$", "$B_y$", "$B_z$", "$C_x$", "$C_y$", "$C_z$"])
plt.xlabel("Time ($M$)")

horizons

plt.semilogy(h.t, h.abs)
plt.xlabel("Time ($M$)")
plt.ylabel(r"$|h_{\ell,m}|$")

waveform