sxs-collaboration / sxs

Python code for manipulating data from the SXS collaboration
MIT License
26 stars 18 forks source link

Possible bug in metadata writing #30

Closed SergeiOssokine closed 4 years ago

SergeiOssokine commented 4 years ago

There appears to be a bug in the method to_json_file in the Metadata class. In particular, this line: https://github.com/sxs-collaboration/sxs/blob/main/sxs/metadata/metadata.py#L273 This line creates a directory ending in .json which breaks things. Removing seems to solve the issue.

moble commented 4 years ago

Thanks. It should be path.parent in that line. I'll fix it shortly.