search

sxs-collaboration / sxs

Python code for manipulating data from the SXS collaboration
MIT License
26 stars 18 forks source link

LVC conversion: "comparable" eccentricities #6

Closed moble closed 4 years ago

moble commented 4 years ago

Moving one part of sxs-collaboration/catalog_tools#3 to this repo, because the code has moved.

@SergeiOssokine said

The function that looks at comparable cases currently only considers the mass ratio and magnitudes of the spins and not their directions (it also does not take into account eccentricity). So a q=5, chi1=(0.9,0.0,0.0) would be considered close to q=5, chi1=(0.0,0.0,0.9).

@geoffrey4444 said

I agree it's not optimal, but it's not obvious to me how to properly fold in everything you might want to look at. Is eccentricity more or less important than mass ratios and spins for determining accuracy?

@aaronbzimmerman said

Eccentricity should probably not be very different for the "similar run" used in error estimates, since an eccentricity 0.1 run isn't really the same as a circular run. Add logic to check that the eccentricity be close enough that only quasi-circular runs are used to estimate errors for quasi-circular runs (maybe check that the difference in eccentricity is less than say 0.01 or 0.05?)

I don't see any problem adding such logic to this function, but I wouldn't feel comfortable making the decisions when I haven't used this format, and don't have any feeling for what LVC people would want. So this looks like a job for Geoffrey.

moble commented 4 years ago

@geoffrey4444 and @haraldp271 agreed that this field should no longer be supported. Specifically, they both agreed that out_file.attrs['comparable-simulation'] = "" would be acceptable in all cases. I can make the change.