In catalog.py lines 66-104. Suppose the user passes download=False and the user has no cache (so not cache_path.exists()). Then line 99 will be hit, testing the value of download_failed, which was never assigned, because the if block starting on line 66 was never entered.
I think the test for download is False just needs to come before the test for download_failed to resolve.
In catalog.py lines 66-104. Suppose the user passes
download=Falseand the user has no cache (sonot cache_path.exists()). Then line 99 will be hit, testing the value ofdownload_failed, which was never assigned, because the if block starting on line 66 was never entered.I think the test for
download is Falsejust needs to come before the test fordownload_failedto resolve.Found by @akhairna.