search

sxs-collaboration / sxs

Python code for manipulating data from the SXS collaboration
MIT License
25 stars 18 forks source link

Fix problem finding json files when loading rpdmb in git annex #74

Closed markscheel closed 1 year ago

markscheel commented 1 year ago

When searching for json files, convert .h5->.json suffixes before traversing symlinks.

This is because a common use case is for files to be in git-annex, where they are symlinked to crazy filenames.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (b4c0a51) 42.29% compared to head (39ef79a) 42.29%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #74 +/- ## ======================================= Coverage 42.29% 42.29% ======================================= Files 70 70 Lines 5578 5578 Branches 1109 1109 ======================================= Hits 2359 2359 Misses 3010 3010 Partials 209 209 ``` | [Impacted Files](https://app.codecov.io/gh/sxs-collaboration/sxs/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sxs-collaboration) | Coverage Δ | | |---|---|---| | [...veforms/rotating\_paired\_diff\_multishuffle\_bzip2.py](https://app.codecov.io/gh/sxs-collaboration/sxs/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sxs-collaboration#diff-c3hzL3dhdmVmb3Jtcy9yb3RhdGluZ19wYWlyZWRfZGlmZl9tdWx0aXNodWZmbGVfYnppcDIucHk=) | `52.56% <66.66%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

markscheel commented 1 year ago

I changed a few things in this PR based on discussion in the bugs meeting today.