search

sxs-collaboration / sxs

Python code for manipulating data from the SXS collaboration
MIT License
25 stars 18 forks source link

Fix `bar` is not a property #87

Closed SSL32081 closed 5 months ago

SSL32081 commented 5 months ago

This pull request attempts to address issue #48, where bar is not a function to be called. Use the original conjugate function define in spherical.modes instead.

This PR also fixes a small frame undefined issue.

📚 Documentation preview 📚: https://sxs--87.org.readthedocs.build/en/87/

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.22%. Comparing base (59c71bf) to head (a6a44c5). Report is 16 commits behind head on main.

Files Patch % Lines
sxs/waveforms/waveform_modes.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #87 +/- ## ========================================== - Coverage 42.29% 42.22% -0.07% ========================================== Files 70 71 +1 Lines 5578 5579 +1 Branches 1236 1236 ========================================== - Hits 2359 2356 -3 - Misses 3010 3017 +7 + Partials 209 206 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

moble commented 5 months ago

Thanks!