search

sxs-collaboration / sxs

Python code for manipulating data from the SXS collaboration
MIT License
25 stars 18 forks source link

Add 4d SO3 optimizer #90

Open keefemitman opened 1 month ago

keefemitman commented 1 month ago

Extend align2d to optimize over the full SO(3) transformation (as well as the time translation).

📚 Documentation preview 📚: https://sxs--90.org.readthedocs.build/en/90/

keefemitman commented 1 month ago

After talking with @duetosymmetry I'll change the optimization space to be over quaternion components

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 4.22535% with 68 lines in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (1031c72) to head (f2a1816). Report is 41 commits behind head on main.

Files Patch % Lines
sxs/waveforms/alignment.py 4.22% 68 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ========================================== + Coverage 39.97% 41.81% +1.84% ========================================== Files 75 78 +3 Lines 6074 6552 +478 Branches 1234 1327 +93 ========================================== + Hits 2428 2740 +312 - Misses 3426 3567 +141 - Partials 220 245 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.