sxyazi / yazi

💥 Blazing fast terminal file manager written in Rust, based on async I/O.
https://yazi-rs.github.io
MIT License
14.31k stars 330 forks source link

konsole terminal cannot automatically clean image previews #1122

Closed DreamMaoMao closed 3 months ago

DreamMaoMao commented 3 months ago

What system are you running Yazi on?

Linux Wayland

What terminal are you running Yazi in?

konsole 23.08.4

Did you try the latest code to see if this problem got fixed?

Tried, but the problem still

yazi --debug output

```sh Yazi Version: 0.2.5 (2c84c48 2024-06-04) Debug : false OS : linux-x86_64 (unix) Ya Version: 0.2.5 Emulator Emulator.via_env: ("xterm-256color", "") Emulator.via_csi: Ok(Konsole) Emulator.detect : Konsole Adaptor Adaptor.matches: Iterm2 Desktop XDG_SESSION_TYPE: Some("wayland") WAYLAND_DISPLAY : Some("wayland-1") DISPLAY : Some(":0") SSH shared.in_ssh_connection: false WSL /proc/sys/fs/binfmt_misc/WSLInterop: false Variables SHELL : Some("/bin/fish") EDITOR : Some("nvim ") ZELLIJ_SESSION_NAME: None YAZI_FILE_ONE : None YAZI_CONFIG_HOME : None Text Opener default: Some(Opener { run: "$EDITOR \"$1\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: false }) block : Some(Opener { run: "$EDITOR \"$1\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: false }) tmux TMUX : false Version: 3.4 Dependencies file : 5.45 ueberzugpp : No such file or directory (os error 2) ffmpegthumbnailer: 2.2.2 magick : 7.1.1-27 fzf : 0.42.0 fd : 9.0.0 rg : 13.0.0 chafa : 1.14.0 zoxide : 0.9.2 unar : ExitStatus(unix_wait_status(32512)), "unar: error while loading shared libraries: libicuuc.so.74: cannot open shared object file: No such file or directory\n" jq : 1.7 -------------------------------------------------- When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time. You can find it in the "/home/wrq/.local/state/yazi" directory. ```

Describe the bug

After selecting an image file, and then selecting another non-image file, the preview of the previous image file remains, and the image is not cleared.

https://github.com/sxyazi/yazi/assets/30348075/168bb6be-ea23-4a47-9091-c1e5fd051fca

Expected Behavior

the image preview should be clear after swith to a non-image file.

To Reproduce

1.select a image file

  1. then select a non-image file

Configuration

No response

Anything else?

No response

sxyazi commented 3 months ago

Try upgrading your Konsole to the latest

DreamMaoMao commented 3 months ago

Try upgrading your Konsole to the latest

still not work

image

image

DreamMaoMao commented 3 months ago

image

this commit cause it

sxyazi commented 3 months ago

Fixed in https://github.com/sxyazi/yazi/commit/5f8c20e2b517faea53680f720553d20ec363e9ab

Switched back to the old kitty protocol as the iterm2 and sixel protocol implementations in Konsole are buggy, https://bugs.kde.org/show_bug.cgi?id=456354.

github-actions[bot] commented 2 months ago

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.