search

sxyazi / yazi

💥 Blazing fast terminal file manager written in Rust, based on async I/O.
https://yazi-rs.github.io
MIT License
16.72k stars 389 forks source link

Use XDG spec for goto navigation. #1879

Closed voronind-com closed 2 weeks ago

voronind-com commented 2 weeks ago

Closes #1878 More info about XDG here.

sxyazi commented 2 weeks ago

Sorry, I'm afraid I can't accept the PR, because this breaks on macOS and Windows, they don't have an XDG_CONFIG_HOME and XDG_DOWNLOAD_DIR at all, but they generally have the ~/.config and ~/Downloads folder

voronind-com commented 2 weeks ago

Sorry, I'm afraid I can't accept the PR, because this breaks on macOS and Windows, they don't have an XDG_CONFIG_HOME and XDG_DOWNLOAD_DIR at all, but they generally have the ~/.config and ~/Downloads folder

Maybe OS detection would help in such cases? Right now it feels sad to lose one platform compatibility for other platforms. Same goes for manpages....

Right now yazi attempts to support all platforms w/o platform-specific features.

sxyazi commented 2 weeks ago

Don't get me wrong - I can accept platform-specific features as long as they don't cause trouble for users on other platforms, and there needs to be a better way to implement it than this PR, maybe as a built-in plugin