sxyu / plenoctree

PlenOctrees: NeRF-SH Training & Conversion
https://alexyu.net/plenoctrees
BSD 2-Clause "Simplified" License
425 stars 78 forks source link

ViewDirs vs Direction in the named tuple `Rays` #21

Open saunair opened 2 years ago

saunair commented 2 years ago

Why not just have the direction field with the origin, and remove the viewdirs field in Rays? The direction field should always contain the normalized direction (unit vector) anyway. If the un-normalized direction doesn't serve a specific purpose, these twin fields will cause confusion