sxyu / svox2

Plenoxels: Radiance Fields without Neural Networks
BSD 2-Clause "Simplified" License
2.79k stars 360 forks source link

Weight decay only applied when printing averaged stats #132

Open EinarSommerfeldt opened 8 months ago

EinarSommerfeldt commented 8 months ago

Hi, I'm looking through opt.py and noticed that the code if args.weight_decay_sh < 1.0: grid.sh_data.data *= args.weight_decay_sigma if args.weight_decay_sigma < 1.0: grid.density_data.data *= args.weight_decay_sh Only runs inside if (iter_id + 1) % args.print_every == 0: Is it intentional to only update weight decay when printing?