search

sxyu / svox2

Plenoxels: Radiance Fields without Neural Networks
BSD 2-Clause "Simplified" License
2.79k stars 359 forks source link

to_svox1 colors #22

Closed ookey closed 1 year ago

ookey commented 2 years ago

Thanks a lot for your outstanding work! Experimenting the export to svox1, I find the colors a bit "greyish". I was wondering if the reason is the sigmoid you apply in volrend, which is not applied (as far as I understood) in svox2?

In svox2 render_lerp_kernel_cuvol.cu (line 102):

            outv += weight * fmaxf(lane_color_total + 0.5f, 0.f);  // Clamp to [+0, infty)

In volrend rt_core.cuh (line 192):

                            out[t] += weight / (1.f + expf(-tmp));

It seems to give better colors by just replacing the above line by:

                            out[t] += weight * min(1., max(0., tmp + 0.5));

What do you think? Did I understand well the fading color problem?

Best regards, Matthieu.

bolshoytoster commented 2 years ago

@SSground

when I use to_svox1.py have a error image

That issue has been fixed in the most recent version of svox1, try running pip install -U svox to update it.

ookey commented 2 years ago

Hello, @SSground , do you confirm the colors are faded out somehow, when you play the result with volrend? or are they correct in your tests?

walsvid commented 2 years ago

same issue

Learningm commented 1 year ago

Did you resolve this problem? I met this same issue "greyish".

Update: The modified code above is the solution.