sxyu / svox2

Plenoxels: Radiance Fields without Neural Networks
BSD 2-Clause "Simplified" License
2.83k stars 360 forks source link

[Question] Clamping predicted image color values to [0,1] range #93

Open hadardasim opened 2 years ago

hadardasim commented 2 years ago

First of all great work, it is very helpful to have training in just a few minutes! My question is about clamping: I am assuming the predicted color image values should be in [0,1] range (if you get values about 1 you will get overflow when multiply by 255 and saving to UINT8). However, I couldn't find anywhere in the code where you limit the value to 1 Can you please let me know if I missed that piece of code or this in not something you explicitly enforce?

Thanks in advance, Hadar