sy6sy2 / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS and Windows.
https://kodi.tv/
Other
6 stars 1 forks source link

Support passthrough audio for tvOS #34

Open phunkyfish opened 5 years ago

phunkyfish commented 5 years ago

Currently there is no option to do so.

kambala-decapitator commented 5 years ago

if I understand correctly, in code it's already present:

Or in fact it doesn't work?

davilla commented 5 years ago

passthrough will only work if the runtime tvOS is 11.2 or under. It vanished above that version

phunkyfish commented 5 years ago

That’s crazy, but explains why this doesn’t work as expected.

phunkyfish commented 5 years ago

It looks like it now just auto selects the best audio to send on to the receiver/TV.

Just tested using Netflix and atmos and it does indeed work as expected.

How this works with kodi is another matter. Will test over the next few days.

davilla commented 5 years ago

atmos handling is special, it's a real passthrough of eac3/atmos but there is no public tvOS API for it.

Only eac3/atmos in an mp4/m4v container played by avplayer, will work.

kambala-decapitator commented 5 years ago

@davilla

but there is no public tvOS API for it

if there's a private API for that, do you know the relative functions/methods? Kodi isn't released in Appstore, so it's not a problem to use private APIs.

phunkyfish commented 5 years ago

This should be documented. Once we get to adding a Wiki page for tvOS let's remember to add this detail.

Memphiz commented 5 years ago

@davilla so no direct i/o anymore? What a petty 👎

davilla commented 5 years ago

Well, passthrough was alway dependent on no one (tvOS) messing with it. It just happened to work by chance in tvOS < 11.2.