search

sy6sy2 / xbmc

Kodi is an award-winning free and open source home theater/media center software and entertainment hub for digital media. With its beautiful interface and powerful skinning engine, it's available for Android, BSD, Linux, macOS, iOS and Windows.
https://kodi.tv/
Other
6 stars 1 forks source link

[Depends/tvOS] Openssl Makefile #37

Closed fuzzard closed 5 years ago

fuzzard commented 5 years ago

Description

Fixes the intermittent build issue

Puts target_platform check inside the iOS OS check to keep all iOS/tvOS in the one if check

sy6sy2 commented 5 years ago

Thank you, what do think of this version of lines 15 to 22:

ifeq ($(OS), ios)
  ifeq ($(TARGET_PLATFORM),appletvos)
    # Need to add "no-async" to avoid "'setcontext' is unavailable: not available on tvOS" error
    CONFIGURE=./Configure iphoneos-cross no-shared zlib no-asm no-async --prefix=$(PREFIX)
  else
    CONFIGURE=./Configure iphoneos-cross no-shared zlib no-asm --prefix=$(PREFIX)
  endif
endif
fuzzard commented 5 years ago

Yeah, agreed. streamlines everything nicely.

sy6sy2 commented 5 years ago

Cool! I will apply your merge and edit history of ATV-PR in order to keep correct commits order.

fuzzard commented 5 years ago

Feel free to just close this and do the update during your rebase. Wasnt sure when you would see this, so that was the only reason i PR'd it before i go to bed, haha.

sy6sy2 commented 5 years ago

Ha ha, ok! Thank you and good night ;-)