search

syamilmj / Aqua-Resizer

Resize WordPress images on the fly
502 stars 208 forks source link

Image metadata and retina display support #49

Closed EusebiuOprinoiu closed 3 years ago

EusebiuOprinoiu commented 10 years ago

Hello! I would like to contribute with a few changes to Aqua Resizer, but I'm new to Github and I'm not really sure if I made the commit the right way. If you didn't get it, here is the fork I made: https://github.com/S3bY/Aqua-Resizer My addition is image metadata, so all images created by the script will be deleted from the server when the original is removed. I also added the retina display support suggested by wpexplorer in this thread: https://github.com/syamilmj/Aqua-Resizer/issues/36

syamilmj commented 10 years ago

Hey there,

If possible, I'd like to avoid making any DB calls from the script due to the nature of the script which runs on each server request (or each image resize). Is it possible to port this out of the script, and instead just implement a hook?

EusebiuOprinoiu commented 10 years ago

I made some changes and now the script queries the database only when the image is resized. I also noticed on the old version the metadata was added to the original image every time the script was running, but now this issue is solved as well. I also removed a few small personal comments I forgot to remove on the original commit. And please excuse my chaotic use of Github. I'm very new to it and haven't figured out how to use it properly.

steve231293 commented 5 years ago

Hello guys, Could you add this feature to lastest version of the plugin, please?