search

syamilmj / Aqua-Resizer

Resize WordPress images on the fly
502 stars 208 forks source link

Parameter Checking Not Correct #69

Open hellixor opened 9 years ago

hellixor commented 9 years ago

The Wiki and Function parameter documentation at the top of the process function specify that either height OR width are required. The process functions forces both to be defined, or an error is thrown.

pixedelic commented 8 years ago

You're right, on line 72 I commented

if (!$height)
   throw new Aq_Exception('$height parameter is required');

and now $height can be null and images have their original ratio. Don't know if the author found some issue with this feature. Hope to hear from him soon.