syamilmj / aqua-page-builder

Aqua Page Builder WordPress Plugin
238 stars 113 forks source link

Compatibility issue with visual composer add link #134

Closed bearandbeagle closed 10 years ago

bearandbeagle commented 10 years ago

Since the 3.9 update, I've been having issues with the visual composer allowing me to add links using the add media button.

I'd click the button, the window would pop up, I'd type in or select my internal page, click add link. And nothing would happen. No link would be created. Didn't work on posts or pages.

I cleared my browser cache before doing anything else, just to makes sure.

After some research, I discovered that others are also having this issue and that Aqua Page Builder was having compatibility issues with TinyMCE. I disabled the plugin and now the link problem is no longer. It's still installed, just deactivated.

I haven't tried changing my theme or disabling all plugins because I really didn't want to do that unless I had to. Since the issue is gone with Aqua Page Builder disabled, it's hard to warrant messing with my plugins and theme more.

I found a list here of issue plugins that lead me to disable the plugin: https://wordpress.org/support/topic/wordpress-39-master-list?replies=5#post-5463816

I just wanted to report this issue. I'm not super technical in terms of development but know my way around WP more than the average person. If you have questions, don't hesitate to ask and I'll try to answer as best I can.

I'm using a theme that came with the plugin from ThemeForest and have also reported the issue to the theme author.

syamilmj commented 10 years ago

Hey thanks for reporting this.

Could you try this very quickly, on a develoemt site or locally:

  1. Change the theme to default WP theme
  2. Disable all plugins except VC and APB

do you still see the conflicts?

Thanks!

bearandbeagle commented 10 years ago

I will have to give it a go later. I have a post publishing in a matter of minutes and can’t do those actions right now without interrupting service for my readers. I’ll try to do it early in the morning. I don’t have a development site so I have to do it locally.

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com 501.825.0421

On Jun 6, 2014, at 7:31 AM, Syamil MJ notifications@github.com wrote:

Hey thanks for reporting this.

Could you try this very quickly, on a develoemt site or locally:

Change the theme to default WP theme Disable all plugins except VC and APB do you still see the conflicts?

Thanks!

— Reply to this email directly or view it on GitHub.

syamilmj commented 10 years ago

No problem Kim. Appreciate your time.

Cheers

bearandbeagle commented 10 years ago

I received this message from the theme developer and thought you’d like to know!

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com 501.825.0421

Begin forwarded message:

From: Theme Stockyard hello@themestockyard.com Subject: Re: [ThemeForest] Message sent via your marketplace profile from bearandbeagle Date: June 6, 2014 at 8:56:45 AM CDT To: Kim Herrington kim@bearandbeaglecreative.com

How interesting...

Okay, I so I found the test site that was having the issue, but I was confused because the live site and the other two test sites were fine. Then... I noticed that for the sites that are working, even though I haven't actually used the page builder templates on any "published" pages, I had at least created a template. For the test site that wasn't working correctly, I had installed the plugin but hadn't actually created any templates using the page builder. So, as soon as I created a "test template" (again, I'm not even using it on any published/live pages), the ability to add links was restored.

I guess that counts as a quick fix/workaround, but how odd.

I'm guessing the plugin developer added some functionality that attempts to inhibit or deactivate the text editor until a template is created? If so, said functionality is (unintentionally I'm sure) carrying over onto the text editors for pages/posts. I'm still looking just to be sure, but I think we're on the right path...

  • Jarrod

On Fri, Jun 6, 2014 at 9:35 AM, Theme Stockyard hello@themestockyard.com wrote: Thanks, Kim!

Yes, please keep me in the loop. I'll keep working on my end to see if I can come up with a quick workaround/fix.

  • Jarrod

On Fri, Jun 6, 2014 at 9:16 AM, Kim Herrington kim@bearandbeaglecreative.com wrote: Fab! Thanks, Jarrod.

The plugin developer has contacted me to try using the default theme and disable all plugins except VC and APB. Of course, I will later but I’m really positive it’s APB.

I didn’t go through the normal steps of doing that before because I saw that APB was the problem and when I disabled, it fixed it. I don’t have a development site so doing this means pretty much interrupting service for my readers. I’m going to give it a try early tomorrow morning while no one is on my site and will let you know if I discover anything odd. But I’m sure I won’t!

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com 501.825.0421

On Jun 6, 2014, at 8:11 AM, Theme Stockyard hello@themestockyard.com wrote:

Hi there, Kim!

Most of the inclement weather in Chattanooga came... maybe two nights ago? And like any true southerner I slept through it like a baby. With that said, it wasn't nearly bad enough where I am that a four-wheeler would get blown around so easily. Not that I remember anything about it since I was sleeping, but when we woke up there was tons of debris (large branches, street signs, etc), but nothing major had been torn down or moved.

Regarding Aqua Page Builder, you're exactly right, it's completely optional and you only need it for building new pages. The theme can work perfectly well without it :)

Oh, and thanks for letting me know what it was. When testing, we experienced it once on one of our test sites, but then the issue mysteriously went away. Now at least I know what the culprit was... I'll contact the plugin developer as well and I'll also look to see if there's any code that I can add to the theme that can fix and/or override whatever the plugin is doing.

I'll let you know if I'm able to come up with anything.

TL;DR: The theme will work perfectly without the Aqua Page Builder plugin ;)

Again, thanks so much for letting me know.

  • Jarrod

On Fri, Jun 6, 2014 at 8:16 AM, Kim Herrington kim@bearandbeaglecreative.com wrote: Hey Jarrod,

Hope all is well over in Tennessee! We didn’t get the nasty weather Eastern Arkansas had last night, thank goodness. Friends had a neighbor’s four-wheeler stuck in the side of their house fifteen feet up this morning when they woke up.

I’ve been having issues with adding links to posts in the visual composer using the add link media button. I’ve been having to manually plop them in which is a pain in the rear for linking to past content.

I started a search to figure out what was wrong and found that people are reporting issues with Aqua Page Builder: https://wordpress.org/support/topic/wordpress-39-master-list?replies=5#post-5463816.

When I disabled the plugin, it fixed the issue. I’m assuming I only need this plugin enabled when I want to build new pages? My site is complete and is just in maintenance mode now of adding posts. Do I need Aqua Page Builder enabled for theme capabilities?

I’m reporting the error to the plugin developer.

Thanks! Kim

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com 501.825.0421

On Jun 6, 2014, at 8:14 AM, Syamil MJ notifications@github.com wrote:

No problem Kim. Appreciate your time.

Cheers

— Reply to this email directly or view it on GitHub.

syamilmj commented 10 years ago

I'm not awfully familiar with VC at all and in fact do not have the plugin handy to test with. If it's anyway possible that someone could send it my way I'd be happy to test it on machine.

I assume the license for VC is GPL (as should all WP plugins) so there shouldn't be any copyright infringement to be concerned about.

My email is at sy4mil@gmail.com

On Friday, June 6, 2014, bearandbeagle notifications@github.com wrote:

I received this message from the theme developer and thought you’d like to know!

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com'); 501.825.0421

Begin forwarded message:

From: Theme Stockyard <hello@themestockyard.com javascript:_e(%7B%7D,'cvml','hello@themestockyard.com');> Subject: Re: [ThemeForest] Message sent via your marketplace profile from bearandbeagle Date: June 6, 2014 at 8:56:45 AM CDT To: Kim Herrington <kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com');>

How interesting...

Okay, I so I found the test site that was having the issue, but I was confused because the live site and the other two test sites were fine. Then... I noticed that for the sites that are working, even though I haven't actually used the page builder templates on any "published" pages, I had at least created a template. For the test site that wasn't working correctly, I had installed the plugin but hadn't actually created any templates using the page builder. So, as soon as I created a "test template" (again, I'm not even using it on any published/live pages), the ability to add links was restored.

I guess that counts as a quick fix/workaround, but how odd.

I'm guessing the plugin developer added some functionality that attempts to inhibit or deactivate the text editor until a template is created? If so, said functionality is (unintentionally I'm sure) carrying over onto the text editors for pages/posts. I'm still looking just to be sure, but I think we're on the right path...

  • Jarrod

On Fri, Jun 6, 2014 at 9:35 AM, Theme Stockyard < hello@themestockyard.com javascript:_e(%7B%7D,'cvml','hello@themestockyard.com');> wrote: Thanks, Kim!

Yes, please keep me in the loop. I'll keep working on my end to see if I can come up with a quick workaround/fix.

  • Jarrod

On Fri, Jun 6, 2014 at 9:16 AM, Kim Herrington < kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com');> wrote: Fab! Thanks, Jarrod.

The plugin developer has contacted me to try using the default theme and disable all plugins except VC and APB. Of course, I will later but I’m really positive it’s APB.

I didn’t go through the normal steps of doing that before because I saw that APB was the problem and when I disabled, it fixed it. I don’t have a development site so doing this means pretty much interrupting service for my readers. I’m going to give it a try early tomorrow morning while no one is on my site and will let you know if I discover anything odd. But I’m sure I won’t!

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com'); 501.825.0421

On Jun 6, 2014, at 8:11 AM, Theme Stockyard <hello@themestockyard.com javascript:_e(%7B%7D,'cvml','hello@themestockyard.com');> wrote:

Hi there, Kim!

Most of the inclement weather in Chattanooga came... maybe two nights ago? And like any true southerner I slept through it like a baby. With that said, it wasn't nearly bad enough where I am that a four-wheeler would get blown around so easily. Not that I remember anything about it since I was sleeping, but when we woke up there was tons of debris (large branches, street signs, etc), but nothing major had been torn down or moved.

Regarding Aqua Page Builder, you're exactly right, it's completely optional and you only need it for building new pages. The theme can work perfectly well without it :)

Oh, and thanks for letting me know what it was. When testing, we experienced it once on one of our test sites, but then the issue mysteriously went away. Now at least I know what the culprit was... I'll contact the plugin developer as well and I'll also look to see if there's any code that I can add to the theme that can fix and/or override whatever the plugin is doing.

I'll let you know if I'm able to come up with anything.

TL;DR: The theme will work perfectly without the Aqua Page Builder plugin ;)

Again, thanks so much for letting me know.

  • Jarrod

On Fri, Jun 6, 2014 at 8:16 AM, Kim Herrington < kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com');> wrote: Hey Jarrod,

Hope all is well over in Tennessee! We didn’t get the nasty weather Eastern Arkansas had last night, thank goodness. Friends had a neighbor’s four-wheeler stuck in the side of their house fifteen feet up this morning when they woke up.

I’ve been having issues with adding links to posts in the visual composer using the add link media button. I’ve been having to manually plop them in which is a pain in the rear for linking to past content.

I started a search to figure out what was wrong and found that people are reporting issues with Aqua Page Builder: https://wordpress.org/support/topic/wordpress-39-master-list?replies=5#post-5463816.

When I disabled the plugin, it fixed the issue. I’m assuming I only need this plugin enabled when I want to build new pages? My site is complete and is just in maintenance mode now of adding posts. Do I need Aqua Page Builder enabled for theme capabilities?

I’m reporting the error to the plugin developer.

Thanks! Kim

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com');

Kim Herrington Bear & Beagle Creative LLC kim@bearandbeaglecreative.com javascript:_e(%7B%7D,'cvml','kim@bearandbeaglecreative.com'); 501.825.0421

On Jun 6, 2014, at 8:14 AM, Syamil MJ <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

No problem Kim. Appreciate your time.

Cheers

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/syamilmj/Aqua-Page-Builder/issues/134#issuecomment-45343600 .