search

syamilmj / aqua-page-builder

Aqua Page Builder WordPress Plugin
238 stars 114 forks source link

Issue #142 Solution #144

Closed ZackWard closed 10 years ago

ZackWard commented 10 years ago

Solution to Issue #142 When cloning a template, check to make sure that the clone name is unique.

ZackWard commented 10 years ago

This is my first github contribution attempt. =)

syamilmj commented 10 years ago

Ok let me have a quick review on this one :)

syamilmj commented 10 years ago 
Fatal error: Can't use function return value in write context in /Users/syamilmj/Sites/cuvette/wp-content/plugins/aqua-page-builder/classes/class-aq-page-builder.php on line 381
syamilmj commented 10 years ago

Fixed. See 1083361a4021b07e2f2a54781aecd3776aefa704

ZackWard commented 10 years ago

Ahh, found the problem. In PHP <5.5 isset() doesn't work with expressions. I've removed that function, but I see that you've already solved the problem. =)

On Sat, Jul 19, 2014 at 11:32 PM, Syamil MJ notifications@github.com wrote:

Fatal error: Can't use function return value in write context in /Users/syamilmj/Sites/cuvette/wp-content/plugins/aqua-page-builder/classes/class-aq-page-builder.php on line 381

— Reply to this email directly or view it on GitHub https://github.com/syamilmj/Aqua-Page-Builder/pull/144#issuecomment-49537694 .

Zack Ward