search

syberalexis / puppet-thanos

This module automates the install of Thanos and it's components into a service.
https://forge.puppet.com/maeq/thanos
Apache License 2.0
4 stars 16 forks source link

feat: add env vars #47

Closed Chr0my closed 11 months ago

Chr0my commented 11 months ago

This PR allows setting custom environment variables inside the systemd service file. It could be needed for specific things, like the elastic APM tracing. i.e : 

env_vars          => ["ELASTIC_APM_SERVER_URL=http://apm-server.domain:8200",
                               "ELASTIC_APM_GLOBAL_LABELS=label1=labelvalue1,label2=labelvalue2]

Generates : 

 [Service]
-
+Environment=ELASTIC_APM_SERVER_URL=http://apm-server.domain:8200
+Environment=ELASTIC_APM_GLOBAL_LABELS=label1=labelvalue1,label2=labelvalue2
Chr0my commented 11 months ago

@syberalexis Do you have a bit of time for this ? The pipeline is failing because a stdlib dependency that is below the one required for prometheus module if I'm not wrong. puppetlabs-stdlib, installed: 6.6.0, expected: >= 9.0.0 < 10.0.0

syberalexis commented 11 months ago

Hello,

It's good for me. I will try to finish to fix the CI next week ;) Sorry for the late answer, my life is very busy.

Chr0my commented 11 months ago

Awesome, thanks a lot for your time 🙏

syberalexis commented 11 months ago

Sorry, i forgot to release… I try to do it this evening.