syberalexis / puppet-thanos

This module automates the install of Thanos and it's components into a service.
https://forge.puppet.com/maeq/thanos
Apache License 2.0
4 stars 16 forks source link

[FEATURE] Support configuration directory for thanos::user (or other) #53

Open Nuno09 opened 4 months ago

Nuno09 commented 4 months ago

Is your feature request related to a problem? Please describe. I am running thanos services with the prometheus user (RHEL/CentOS OS). But I have an issue with the thanos config dir always owned by 'root'. I don't understand why, is there a reason behind this?

Describe the solution you'd like Support to set the 'config_dir' owner to the user running thanos.

Describe alternatives you've considered I don't see any

Additional context Here is the exact place this is done: https://github.com/syberalexis/puppet-thanos/blob/a59248ae8159618472387cf3f8470f62835a500f/manifests/install.pp#L128

Nuno09 commented 4 months ago

I have a proposed PR: https://github.com/syberalexis/puppet-thanos/pull/54