sybila / biodivine-lib-bdd

A small library for BDD manipulation in Rust. Part of the BioDivine toolset.
MIT License
20 stars 4 forks source link

Isses with BDD serialisation on buffered reader/writer #34

Closed daemontus closed 1 year ago

daemontus commented 1 year ago

Right now, "raw" serialisation is written such that it must always consume input in 10-byte chunks. However, some writers will not return continuous 10-byte chunks. For example, a buffered writer will only return 10-byte chunks if its buffer is a multiple of 10. Otherwise it will clip the "last" chunk to match the length of the buffer, in which case the reading can still continue, but the loop in our de-serialisation routine will stop becuase it was expecting a 10-byte chunk.

daemontus commented 1 year ago

This should be hopefully fixed in 0.5.1.