sybila / biodivine-lib-param-bn

Rust library for working with parametrised Boolean networks.
MIT License
2 stars 2 forks source link

Fix `Eq` and `PartialEq` implementation for Boolean network #24

Closed daemontus closed 2 years ago

daemontus commented 3 years ago

At the moment, Eq and PartialEq for Boolean network rely on a specific variable/parameter/regulation ordering. This is reasonable, but it is not exactly intuitive. It would be better to test regardless of ordering (especially for regulations).

daemontus commented 2 years ago

The question is how do you handle equivalence of Boolean functions. We will probably need multiple equivalence methods with different semantics:

daemontus commented 2 years ago

For now, closed with 64a02d2d6b1de45a896b0057d65e76e0af4a1aa0. This effectively fixes the syntactic equality issues and leaves the semantic equality as possible further enhancement.