sybila / biodivine-lib-param-bn

Rust library for working with parametrised Boolean networks.
MIT License
2 stars 2 forks source link

Extended symbolic domain #39

Closed daemontus closed 1 year ago

daemontus commented 1 year ago

This PR should mostly generalise the work completed as part of dev-hctl by @ondrej33, such that the resulting SymbolicContext can be also used for other applications that assume multiple BDD variables associated to every network variable.

Overall, there shouldn't be any breaking changes, however, there is a minor adjustment to how symbolic set operations are implemented which I wanted to do for quite some time.

daemontus commented 1 year ago

@ondrej33: Can you please review this PR to check that it is indeed sufficient for your implementation of the HCTL model checker? (Also, feel free to merge it after the review, so that you are the one who commits it to master and thus appears in the list of contributors ;))

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.64% // Head: 76.90% // Increases project coverage by +0.25% :tada:

Coverage data is based on head (1687a62) compared to base (d23032d). Patch coverage: 74.10% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #39 +/- ## ========================================== + Coverage 76.64% 76.90% +0.25% ========================================== Files 71 72 +1 Lines 4059 4113 +54 ========================================== + Hits 3111 3163 +52 - Misses 948 950 +2 ``` | [Impacted Files](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila) | Coverage Δ | | |---|---|---| | [src/symbolic\_async\_graph/bdd\_set.rs](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila#diff-c3JjL3N5bWJvbGljX2FzeW5jX2dyYXBoL2JkZF9zZXQucnM=) | `45.83% <45.83%> (ø)` | | | [src/symbolic\_async\_graph/\_impl\_symbolic\_context.rs](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila#diff-c3JjL3N5bWJvbGljX2FzeW5jX2dyYXBoL19pbXBsX3N5bWJvbGljX2NvbnRleHQucnM=) | `85.71% <77.50%> (-2.86%)` | :arrow_down: | | [src/symbolic\_async\_graph/\_impl\_graph\_colors.rs](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila#diff-c3JjL3N5bWJvbGljX2FzeW5jX2dyYXBoL19pbXBsX2dyYXBoX2NvbG9ycy5ycw==) | `56.41% <77.77%> (+6.41%)` | :arrow_up: | | [src/symbolic\_async\_graph/\_impl\_graph\_vertices.rs](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila#diff-c3JjL3N5bWJvbGljX2FzeW5jX2dyYXBoL19pbXBsX2dyYXBoX3ZlcnRpY2VzLnJz) | `53.22% <77.77%> (+6.74%)` | :arrow_up: | | [...mbolic\_async\_graph/\_impl\_graph\_colored\_vertices.rs](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila#diff-c3JjL3N5bWJvbGljX2FzeW5jX2dyYXBoL19pbXBsX2dyYXBoX2NvbG9yZWRfdmVydGljZXMucnM=) | `57.89% <80.00%> (-1.79%)` | :arrow_down: | | [...symbolic\_async\_graph/\_impl\_symbolic\_async\_graph.rs](https://codecov.io/gh/sybila/biodivine-lib-param-bn/pull/39/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila#diff-c3JjL3N5bWJvbGljX2FzeW5jX2dyYXBoL19pbXBsX3N5bWJvbGljX2FzeW5jX2dyYXBoLnJz) | `81.69% <95.00%> (+3.05%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sybila)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.