sybila / biodivine-lib-param-bn

Rust library for working with parametrised Boolean networks.
MIT License
2 stars 2 forks source link

Bug in `infer_regulatory_graph` when working with parameters #49

Closed daemontus closed 7 months ago

daemontus commented 9 months ago

If we have a network with zero-arity parameters and non-observable regulation, we have an error in infer_regulatory_graph.

Specifically, the string conversion fails to produce a parse-able result because it will contain p[] instead of p. Overall, the conversion is just wrong whenever there are any parameters involved (see L373-L377).

We will probably need to do some kind of better syntactic conversion or something else. Maybe just replace non-observable variables with true/false and propagate the constants? If they truly are non-observable, the result should be equivalent.

daemontus commented 7 months ago

Should be fixed in #52.