search

sybrenstuvel / flickrapi

Python Flickr API implementation
https://stuvel.eu/flickrapi
Other
155 stars 33 forks source link

Updated urls in documentation, docstrings, and shorturl module to use https. #114

Closed okzach closed 6 years ago

okzach commented 6 years ago

Went through the documentation and docstrings and updated urls to use https instead of http (where available) and also updated url locations where changed.

Updated the flickrapi.shorturl module and its tests to use https for the short url produced.

There are still some urls in the oauth_test_*.py files that are http, but maybe should be https now, I did not verify or update them.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 71.156% when pulling 44f683599c8141a25447b7c4da9ab1e2e00016cf on okzach:https-update into 8aee520e9bd873d63d0c2cfa57e8ef7e4551ff10 on sybrenstuvel:master.

sybrenstuvel commented 6 years ago

Thanks!

hugovk commented 5 years ago

Thanks, was just about to send a PR for this!

HTTP shorturls are no longer returning the correct metadata to show the photo in tweets. HTTPS shorturls do work.

For example, test http://flic.kr/p/4s84d3 and https://flic.kr/p/4s84d3 at the Twitter card validator:

HTTP HTTPS
image image

Please could we have a new release with this fix? Thank you!