search

sybrenstuvel / flickrapi

Python Flickr API implementation
https://stuvel.eu/flickrapi
Other
155 stars 33 forks source link

Fix deprecation warnings #120

Closed hugovk closed 4 years ago

hugovk commented 5 years ago

assertEquals is deprecated and causes these warnings in the build logs:

=============================== warnings summary ===============================
tests/test_tokencache.py::SimpleTokenCacheTest::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:14: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token, 'nümbér')
tests/test_tokencache.py::TokenCacheTest::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:44: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token, u'nümbér')
tests/test_tokencache.py::TokenCacheTest::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:46: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(on_disk.decode('utf8'), u'nümbér')
tests/test_tokencache.py::TokenCacheTest::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:50: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token, u'nümbér')
tests/test_tokencache.py::TokenCacheTest::test_username
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:69: DeprecationWarning: Please use assertNotEqual instead.
    self.assertNotEquals(tc_path, user_path)
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:99: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.token, u'nümbér')
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:103: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.token, u'nümbér')
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:104: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.token_secret, u'səcret-tøken')
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:105: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.access_level, u'read')
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:106: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.fullname, u'My Full Name™')
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:107: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.username, u'üsernåme')
tests/test_tokencache.py::OAuthTokenCache::test_get_set_del
  /home/travis/build/sybrenstuvel/flickrapi/tests/test_tokencache.py:108: DeprecationWarning: Please use assertEqual instead.
    self.assertEquals(self.tc.token.user_nsid, u'user—nsid')

https://travis-ci.org/sybrenstuvel/flickrapi/jobs/490922491#L716

This PR updates to use assertEqual, and updates some other asserts to give more informative messages if they fail.

hugovk commented 5 years ago

The CI failure is unrelated and will be fixed by https://github.com/sybrenstuvel/flickrapi/pull/119.

sybrenstuvel commented 4 years ago

Thanks! I've cherrypicked the 'more useful asserts' commit; the other one I already did before I saw your PR :/