Post params as payload, not uri

u1735067 commented 7 years ago

Post params as payload, not uri Because when you try to reorder big sets, you'll get "414 Request-URI Too Large" if you put all ids in uri ..

Not tested yet, but should be ok.

sybrenstuvel commented 7 years ago

Please make sure all unit tests pass before sending a pull request.

u1735067 commented 7 years ago

I'm not going to handle the tests. Instead of creating an issue, I'm pushing a fix, and :

after a short manual test, I can say it works ;
I don't have the dependencies to run the tests on my host (but your travis-ci is here to help -- requires to make a pull request though ;) ) ;
by curiosity I looked to fix tests : while it's not this complicated to fix the test, it's not as simple as passing an argument, you have to setup a callback, check the passed payload, etc etc .. I don't have time for this.

I simply offer a fix for what is an issue to me, do whatever you want with it ;)

Nb: responses's test module "Connection refused" is a stupid message to say there's no preconf answer.

sybrenstuvel commented 7 years ago

"I'm not going to handle the tests." -- in that case I can't accept the pull request.

u1735067 commented 7 years ago

This should be an issue then ;)

sybrenstuvel commented 7 years ago

It was covered by issue #74, which I fixed in commit e64c2aaeeaaddba1ce19021b5db0e03813f6371e ;-)

sybrenstuvel commented 7 years ago

PS: Love your avatar! David Revois' avatar generator, I guess. Great guy :)

u1735067 commented 7 years ago

Oh, nice :) And yes, customly made using the ora file provided (and modified to have meaningful layer names) :)

sybrenstuvel / flickrapi