SEO Framework Version: 5.0.0 broke my site

scottmasterton commented 1 year ago

Just wanted to update you that your plugin broke my website today. I noticed straight away but also got this email:

WordPress has a built-in feature that detects when a plugin or theme causes a fatal error on your site, and notifies you with this automated email.

In this case, WordPress caught an error with one of your plugins, The SEO Framework.

When seeking help with this issue, you may be asked for some of the following information: WordPress version 6.4.1 Active theme: Divi Child Theme (version 1.0.0) Current plugin: The SEO Framework (version 5.0.0) PHP version 7.4.33

SEO Framework Version: 5.0.0

I immediately disabled your plugin and my site is working again.

I don't know enough to give you any more helpful information, sorry.

sybrew commented 1 year ago

Hi there! Thanks for reaching out.

Could you still access the site with the plugin enabled, even after you got the email?

It is possible that file or opcode caching on the server may interfere with the updating process.

For a brief moment after updating, those caches may still interpret the old files, leading to a crash because of inconsistencies. This usually resolves itself within 5 to 15 seconds, but WordPress may yet shoot an email in that period.

Please try activating the plugin and see if you can still use your website. The fatal error email shouldn't be sent again. If you still get errors, please let me know. Cheers!

scottmasterton commented 1 year ago

Hi, I just tried again just now, when activating the pluging I get the same error on my site, although I perhaps should have specified it is only on some parts of the site. This is the error I get in a browser when trying to access the site:

Screenshot 2023-11-23 154613

scottmasterton commented 1 year ago

I've just cleared all the site caches that I can find and I've cleared the browser cache and it made no difference. When I deactivate your plugin the site works as normal again.

sybrew commented 1 year ago

I meant the filesystem cache, something your website cannot control.

I have a copy of Divi and couldn't replicate a crash. I also scanned their code; they haven't done anything specific for The SEO Framework. So, I'm lost on where to look for the issue.

Could you please enable debugging in WordPress by setting WP_DEBUG to true in wp-config.php? https://wordpress.org/documentation/article/debugging-in-wordpress/#wp_debug

When you encounter the error this time, you should see much more text appear. This text will point directly to where the issue begins and ends, and it'll help me fix it.

If you'd rather keep that debugging output confidential, you may share it via our contact page: https://tsf.fyi/contact.

Thank you!

sybrew commented 12 months ago

We may have narrowed it down to alt-tags for social images: If an alt tag has over 420 characters and TSF uses it for social sharing, visiting or editing the page will lead to a crash.

If this sounds familiar to you, the upcoming v5.0.1 patch will fix the crash on your site.

scottmasterton commented 12 months ago

Hi, thanks for looking into this. So I have tried what you asked. I reactivated the plugin and set: define( 'WP_DEBUG', true );

It didn't seem to do anything, I get the same error on the website, there was no additional text to help identify the issue.

I then set:

define( 'WP_DEBUG', true ); define( 'WP_DEBUG_DISPLAY', false ); define( 'WP_DEBUG_LOG', true );

I can't find a debug log anywhere, I believe it should be in wp-content, but it's not there.

I then set

define( 'WP_DEBUG', true ); define( 'WP_DEBUG_DISPLAY', true); define( 'WP_DEBUG_LOG', true );

Still no additional error message on website and still no debug log that I can find.

My site is hosted on Siteground.

Here is where the issue is on my site, this is the problem gallery of images, I haven't checked it there are other problem galleries, and yes that particular gallery is likely to have much larger than normal alt tags, so yes that might be the issue.

https://www.fascinatinglight.com/generative-ai-images/

I'm deactivating the plugin again now.

scottmasterton commented 12 months ago

Tried one last thing but still nothing, if it's there I can't find that log

define( 'WP_DEBUG', true ); define( 'WP_DEBUG_DISPLAY', false ); define( 'WP_DEBUG_LOG', true ); define( 'WP_DEBUG_LOG', '/tmp/wp-errors.log' );

scottmasterton commented 12 months ago

I installed a debug plugin and this is what I get from its log

Real Media Library is part of what I use to display the galleries along with Essential Grid.

sybrew commented 12 months ago

Thank you for following up!

The issues you listed pertain to JavaScript, not PHP -- those errors shouldn't crash your site but may disrupt the editing or viewing experience. With JavaScript on your site, Siteground's Optimizer has a bug optimizing JS/CSS assets; I recommend disabling such features as they're generally ineffective and can actually slow down your site.

Nevertheless, it's easiest to wait a bit for TSF v5.0.1 with the alt-tag fix. Let's look further from there :) I hope to have it out in a few hours. I still have to churn 20 requests to see if there's anything else I can fix for TSF v5.0.1.

scottmasterton commented 12 months ago

Thank you for the update, that does seem to have resolved the issue.

many thanks

On Fri, 24 Nov 2023 at 15:20, Sybre Waaijer @.***> wrote:

Thank you for following up!

The issues you listed pertain to JavaScript, not PHP -- those errors shouldn't crash your site but may disrupt the editing or viewing experience. With JavaScript on your site, Siteground's Optimizer has a bug optimizing JS/CSS assets; I recommend disabling such features as they're generally ineffective and can actually slow down your site.

Nevertheless, it's easiest to wait a bit for TSF v5.0.1 with the alt-tag fix. Let's look further from there :) I hope to have it out in a few hours. I still have to churn 20 requests to see if there's anything else I can fix for TSF v5.0.1.

— Reply to this email directly, view it on GitHub https://github.com/sybrew/The-SEO-Framework-Extension-Manager/issues/81#issuecomment-1825814016, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAPMBX6A4BWML6PCLHOFHLYGC3LDAVCNFSM6AAAAAA7XXMKFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRVHAYTIMBRGY . You are receiving this because you authored the thread.Message ID: @.*** com>

sybrew / The-SEO-Framework-Extension-Manager

SEO Framework Version: 5.0.0 broke my site #81