sybrew / the-seo-framework

The SEO Framework WordPress plugin.
https://theseoframework.com/
GNU General Public License v3.0
417 stars 46 forks source link

Maintain SEO Post Meta revision cache. #48

Open sybrew opened 7 years ago

sybrew commented 7 years ago

From Philipp's support question.

When wp-cron is fired, no post meta gets saved. This is because we don't maintain Post Meta revision data. To resolve this, and prevent plugin conflicts, we could save post meta in a revision, from which the data propagates to the actual outcome.

In order to do so, more investigation on this actual behavior needs to precede.

sybrew commented 5 years ago

This is a lack of functionality in WordPress.

See: https://core.trac.wordpress.org/ticket/20564

Alternative implementation (I'm not in favor): https://gist.github.com/johnbillion/5225514 I'd rather implement #185 first and append revision-states to that:

[
   'live' => [],
   'revision' => [ 
      42 => [],
      43 => [],
    ],
]
sybrew commented 11 months ago

Ticket 20564 will be merged in Core for WordPress 6.4. Here's the dev note: https://make.wordpress.org/core/2023/10/24/framework-for-storing-revisions-of-post-meta-in-6-4/

185 may be worked on beforehand.

However, I am considering moving to a custom metadata table. That'd allow joins in queries, but it would hold us from directly benefiting from the revisions API.