sybrew / the-seo-framework

The SEO Framework WordPress plugin.
https://theseoframework.com/
GNU General Public License v3.0
421 stars 47 forks source link

Update Gutenberg's permalink store when selecting a primary term. #651

Open sybrew opened 1 year ago

sybrew commented 1 year ago

When selecting a Primary Term in Gutenberg / Block Editor, the permalinks in Gutenberg's interface are only updated after we save and refresh the page.

We should do this dynamically by updating Gutenberg's data store.

sybrew commented 1 month ago

Resolving this issue started with https://github.com/sybrew/the-seo-framework/commit/9e7ab9b6e56f00e04b6d293c58f502625ab22640.

sybrew commented 2 weeks ago

In 2fb928b32b163704699248bc1fb0ad5a617aacc8, I fixed the canonical URL prediction about this.

From this experience, I'm convinced we should not affect Gutenberg's canonical URL like this. It's a lot more involved than I first thought. Gutenberg's URL prediction listens only to post slug and category changes -- it does not respond to anything else, such as the date, post ancestors, etc. We can assume that it's broken.

Still, when saving the post, Gutenberg updates the canonical URL but does not appear to respond to the primary term selection. A second save resolves that.

We may want to see if we can save our metadata before Gutenberg fetches new stuff. I'm punting that to a future release, for we're out of time for WP 6.7.