search

sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Rename derive proc-macro `Prop` to `Props` #503

Closed alexisfontaine closed 1 year ago

alexisfontaine commented 1 year ago

Closes #496

codecov[bot] commented 1 year ago

Codecov Report

Base: 64.65% // Head: 64.65% // No change to project coverage :thumbsup:

Coverage data is based on head (c650872) compared to base (20b6069). Patch coverage: 60.86% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #503 +/- ## ======================================= Coverage 64.65% 64.65% ======================================= Files 52 52 Lines 8525 8525 ======================================= Hits 5512 5512 Misses 3013 3013 ``` | [Impacted Files](https://codecov.io/gh/sycamore-rs/sycamore/pull/503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | Coverage Δ | | |---|---|---| | [packages/sycamore-macro/src/view/parse.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3ZpZXcvcGFyc2UucnM=) | `98.36% <ø> (ø)` | | | [packages/sycamore/src/web/portal.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUvc3JjL3dlYi9wb3J0YWwucnM=) | `0.00% <0.00%> (ø)` | | | [website/src/content.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-d2Vic2l0ZS9zcmMvY29udGVudC5ycw==) | `0.00% <0.00%> (ø)` | | | [packages/sycamore-router/src/router.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtcm91dGVyL3NyYy9yb3V0ZXIucnM=) | `27.88% <33.33%> (ø)` | | | [packages/sycamore-macro/src/props.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3Byb3BzLnJz) | `72.09% <50.00%> (ø)` | | | [packages/sycamore/src/flow.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUvc3JjL2Zsb3cucnM=) | `35.48% <50.00%> (ø)` | | | [packages/sycamore-core/src/component.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtY29yZS9zcmMvY29tcG9uZW50LnJz) | `46.87% <100.00%> (ø)` | | | [packages/sycamore-macro/src/component/mod.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL2NvbXBvbmVudC9tb2QucnM=) | `96.42% <100.00%> (ø)` | | | [packages/sycamore-macro/src/lib.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL2xpYi5ycw==) | `86.20% <100.00%> (ø)` | | | [packages/sycamore/src/suspense.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUvc3JjL3N1c3BlbnNlLnJz) | `94.57% <100.00%> (ø)` | | | ... and [1 more](https://codecov.io/gh/sycamore-rs/sycamore/pull/503/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lukechu10 commented 1 year ago

Thanks for contributing! There were two cases where I think it would be better if it remained as "prop" instead of "props" so I reverted the changes. Otherwise, everything else looks good!