sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Remove legacy component syntax and introduce `Component` trait #533

Closed lukechu10 closed 1 year ago

lukechu10 commented 1 year ago

Closes #509 and #493

codecov[bot] commented 1 year ago

Codecov Report

Base: 64.86% // Head: 65.13% // Increases project coverage by +0.26% :tada:

Coverage data is based on head (388c382) compared to base (74dc73c). Patch coverage: 84.28% of modified lines in pull request are covered.

:exclamation: Current head 388c382 differs from pull request most recent head e19b670. Consider uploading reports for the commit e19b670 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #533 +/- ## ========================================== + Coverage 64.86% 65.13% +0.26% ========================================== Files 53 53 Lines 8527 8492 -35 ========================================== Hits 5531 5531 + Misses 2996 2961 -35 ``` | [Impacted Files](https://codecov.io/gh/sycamore-rs/sycamore/pull/533?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | Coverage Δ | | |---|---|---| | [packages/sycamore-macro/src/view/ir.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3ZpZXcvaXIucnM=) | `100.00% <ø> (ø)` | | | [website/src/content.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-d2Vic2l0ZS9zcmMvY29udGVudC5ycw==) | `0.00% <0.00%> (ø)` | | | [website/src/header.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-d2Vic2l0ZS9zcmMvaGVhZGVyLnJz) | `0.00% <0.00%> (ø)` | | | [website/src/sidebar.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-d2Vic2l0ZS9zcmMvc2lkZWJhci5ycw==) | `0.00% <0.00%> (ø)` | | | [website/src/versions.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-d2Vic2l0ZS9zcmMvdmVyc2lvbnMucnM=) | `0.00% <0.00%> (ø)` | | | [packages/sycamore-core/src/component.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtY29yZS9zcmMvY29tcG9uZW50LnJz) | `58.13% <92.30%> (+11.26%)` | :arrow_up: | | [packages/sycamore-macro/src/component/mod.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL2NvbXBvbmVudC9tb2QucnM=) | `96.04% <100.00%> (-0.39%)` | :arrow_down: | | [packages/sycamore-macro/src/props.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3Byb3BzLnJz) | `72.18% <100.00%> (+0.08%)` | :arrow_up: | | [packages/sycamore-macro/src/view/codegen.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3ZpZXcvY29kZWdlbi5ycw==) | `97.45% <100.00%> (-0.05%)` | :arrow_down: | | [packages/sycamore-macro/src/view/parse.rs](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3ZpZXcvcGFyc2UucnM=) | `98.34% <100.00%> (-0.03%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/sycamore-rs/sycamore/pull/533/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.