sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Update MSRV to 1.72 #625

Closed lukechu10 closed 1 year ago

lukechu10 commented 1 year ago

Fixes broken CI

Also updates NodeJS version in CI to 18.x

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03% :tada:

Comparison is base (6bb700b) 62.17% compared to head (da82410) 62.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #625 +/- ## ========================================== + Coverage 62.17% 62.21% +0.03% ========================================== Files 54 54 Lines 9413 9408 -5 ========================================== Hits 5853 5853 + Misses 3560 3555 -5 ``` | [Files Changed](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | Coverage Δ | | |---|---|---| | [packages/sycamore-core/src/generic\_node.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtY29yZS9zcmMvZ2VuZXJpY19ub2RlLnJz) | `79.31% <0.00%> (+2.21%)` | :arrow_up: | | [packages/tools/bench-diff/src/main.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvdG9vbHMvYmVuY2gtZGlmZi9zcmMvbWFpbi5ycw==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.