sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Reactivity v3 (Part 2) #626

Closed lukechu10 closed 12 months ago

lukechu10 commented 1 year ago

This is the follow-up to #612.

Tasks:

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

codecov[bot] commented 1 year ago

Codecov Report

Attention: 529 lines in your changes are missing coverage. Please review.

Comparison is base (3b0cd66) 66.97% compared to head (98951d5) 61.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #626 +/- ## ========================================== - Coverage 66.97% 61.20% -5.78% ========================================== Files 63 55 -8 Lines 11153 9042 -2111 ========================================== - Hits 7470 5534 -1936 + Misses 3683 3508 -175 ``` | [Files](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | Coverage Δ | | |---|---|---| | [packages/sycamore-core/src/generic\_node.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtY29yZS9zcmMvZ2VuZXJpY19ub2RlLnJz) | `78.57% <100.00%> (-0.74%)` | :arrow_down: | | [packages/sycamore-core/src/stable\_id.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtY29yZS9zcmMvc3RhYmxlX2lkLnJz) | `100.00% <100.00%> (ø)` | | | [packages/sycamore-futures/src/lib.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtZnV0dXJlcy9zcmMvbGliLnJz) | `100.00% <100.00%> (ø)` | | | [packages/sycamore-macro/src/lib.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL2xpYi5ycw==) | `85.71% <ø> (ø)` | | | [packages/sycamore-macro/src/view/codegen.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3ZpZXcvY29kZWdlbi5ycw==) | `90.70% <100.00%> (-0.60%)` | :arrow_down: | | [packages/sycamore-macro/src/view/ir.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtbWFjcm8vc3JjL3ZpZXcvaXIucnM=) | `100.00% <ø> (ø)` | | | [packages/sycamore-reactive/src/effects.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtcmVhY3RpdmUvc3JjL2VmZmVjdHMucnM=) | `100.00% <100.00%> (ø)` | | | [packages/sycamore-reactive/src/iter.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtcmVhY3RpdmUvc3JjL2l0ZXIucnM=) | `98.19% <100.00%> (+0.41%)` | :arrow_up: | | [packages/sycamore-reactive/src/memos.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtcmVhY3RpdmUvc3JjL21lbW9zLnJz) | `98.71% <100.00%> (ø)` | | | [packages/sycamore-reactive/src/utils.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtcmVhY3RpdmUvc3JjL3V0aWxzLnJz) | `41.86% <ø> (ø)` | | | ... and [33 more](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/626/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

########################################################################## 01_run1k | 13.04 | 22.42 | 22.30 | -0.53% 02_replace1k | 18.46 | 41.57 | 40.61 | -2.31%

github-actions[bot] commented 1 year ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################

github-actions[bot] commented 12 months ago

Benchmark Report

| wasm-bindgen | baseline | update | diff

##########################################################################