search

sycamore-rs / sycamore

A library for creating reactive web apps in Rust and WebAssembly
https://sycamore-rs.netlify.app
MIT License
2.79k stars 148 forks source link

Re-export `wasm-bindgen`, `js-sys`, and event types from `web-sys` #642

Closed lukechu10 closed 11 months ago

lukechu10 commented 11 months ago

Supersedes #568

This adds a re-export in sycamore-web of wasm-bindgen, js-sys, and only the event types from web-sys which are used from within Sycamore.

The reason why we don't re-export the entirety of web-sys is because all of the APIs are behind feature flags so it is very likely that the downstream user of Sycamore will need to add web-sys as a dependency anyways.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc25aae) 61.19% compared to head (71ba06a) 61.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #642 +/- ## ======================================= Coverage 61.19% 61.19% ======================================= Files 55 55 Lines 9022 9022 ======================================= Hits 5521 5521 Misses 3501 3501 ``` | [Files](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs) | Coverage Δ | | |---|---|---| | [packages/sycamore-web/src/lib.rs](https://app.codecov.io/gh/sycamore-rs/sycamore/pull/642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sycamore-rs#diff-cGFja2FnZXMvc3ljYW1vcmUtd2ViL3NyYy9saWIucnM=) | `20.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.